chore(file upload): img updates#4604
Merged
Merged
Conversation
Collaborator
Contributor
There was a problem hiding this comment.
two small comments:
(1) the input field should be the default state here, not read-only
(2) it might not matter, but this image and the loading state image both don't have backgrounds (the others do, so I just thought I'd point it out)
bekah-stephens
approved these changes
May 8, 2025
Contributor
bekah-stephens
left a comment
bekah-stephens
left a comment
There was a problem hiding this comment.
left a couple of comments on one of the images, but other than that it lgtm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4526