-
Notifications
You must be signed in to change notification settings - Fork 148
docs(inline edit): Updates images for v6. #4613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just adding a note for Docs here since it's contextually related, but might want to update the content to call out the specific icon names (right now we just say check and close, but I think we should do fa-check or whatever) |
|
bekah-stephens marked this conversation as resolved.
|
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also note for Docs, i think some of the bullet points related to this aren't applicable anymore, need to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the gif came out teeny tiny 😆 🤏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So yeah if it's showing valid behavior then I agree with you that's a weird placement currently. I think there should really be a Behavior section that holds that gif, where we describe the interaction.. Hm, do you want to create an h2 ##Behavior between the Usage and Variations section, and just stick the gif there for this pr? I could add the content in a Docs follow up