Skip to content

fix(Cookies/GDPR): moved location in DOM for keyboard a11y #5016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thatblindgeye merged 3 commits into from
May 15, 2026
Merged

fix(Cookies/GDPR): moved location in DOM for keyboard a11y #5016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea4eca2
fix(Cookies/GDPR): moved location in DOM for keyboard a11y
thatblindgeye May 15, 2026
6c2beae
Add comment
thatblindgeye May 15, 2026
20f3cfd
Used zindex token
thatblindgeye May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/documentation-framework/layouts/sideNavLayout/sideNavLayout.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@
flex: 1;
}

#ws-page-banners {
z-index: var(--pf-t--global--z-index--2xl);
}

/* Search */
#algolia-autocomplete-listbox-0 {
/* Fix search results overflowing page */
Expand Down
10 changes: 6 additions & 4 deletions packages/documentation-framework/layouts/sideNavLayout/sideNavLayout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,12 @@ export const SideNavLayout = ({ children, groupedRoutes, navOpen: navOpenProp })
return (
<React.Fragment>
<RtlContext.Provider value={isRTL}>
{/* These alert banners need to be one of the first focusable items so users navigating via
keybaord can dismiss them early in their navigation. */}
<div id="ws-page-banners">
<NavAnnouncementBanner />
{hasGdprBanner && <GdprBanner />}
</div>
<Page
id="ws-page"
mainContainerId="ws-page-main"
Expand All @@ -363,10 +369,6 @@ export const SideNavLayout = ({ children, groupedRoutes, navOpen: navOpenProp })
{children}
{process.env.hasFooter && <Footer isDarkTheme={isDarkTheme} />}
</Page>
<div id="ws-page-banners">
<NavAnnouncementBanner />
{hasGdprBanner && <GdprBanner />}
</div>
</RtlContext.Provider>
</React.Fragment>
);
Expand Down
Loading