test: npm test script to not do coverage #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The npm test script shouldn't include coverage by default, that should itself be a separate command. In most cases you would locally run tests normally without coverage in majority of the cases Instead I added a new npm script test:coverage that includes coverage, and changed npm script test to be --watch by default
Venefilyn
force-pushed
the
test/change-npm-scripts
branch
from
570be1a to
f30a384
Compare
redallen
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The npm test script shouldn't include coverage by default, that should
itself be a separate command. In most cases you would locally run tests
normally without coverage in majority of the cases
Instead I added a new npm script test:coverage that includes coverage,
and changed npm script test to be --watch by default