Skip to content

Commit 033a38b

Browse files
lucasponcejeff-phillips-18
authored andcommitted
fix(Slider): Update state when properties are updated. (#1223)
1 parent abab0d4 commit 033a38b

File tree

1 file changed

+8
-1
lines changed
  • packages/patternfly-3/patternfly-react/src/components/Slider

1 file changed

+8
-1
lines changed

packages/patternfly-3/patternfly-react/src/components/Slider/Slider.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,19 @@ class Slider extends React.Component {
1717
};
1818
}
1919

20+
componentDidUpdate(prevProps) {
21+
if (prevProps.value !== this.props.value) {
22+
this.onSlide(this.props.value);
23+
}
24+
}
25+
2026
onSlide = value => {
2127
this.setState({ value }, () => this.props.onSlide(value));
2228
};
2329

2430
onInputChange = event => {
25-
this.setState({ value: parseInt(event.target.value || 0, 10) });
31+
const newValue = parseInt(event.target.value || 0, 10);
32+
this.setState({ value: newValue }, () => this.props.onSlide(newValue));
2633
};
2734

2835
onFormatChange = format => {

0 commit comments

Comments
 (0)