Skip to content

Commit 93ed571

Browse files
cbenjeff-phillips-18
authored andcommitted
fix(ModelessOverlay): allow vertical scrolling (#796)
1 parent 3400a44 commit 93ed571

File tree

4 files changed

+62
-0
lines changed

4 files changed

+62
-0
lines changed

packages/patternfly-3/patternfly-react/less/modeless-overlay.less

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,13 @@
66

77
.modal-content {
88
height: ~'calc(100vh - @{navbar-pf-height})';
9+
display: flex;
10+
flex-direction: column;
11+
12+
.modal-body {
13+
flex-grow: 1;
14+
overflow: hidden auto;
15+
}
916
}
1017
}
1118

packages/patternfly-3/patternfly-react/sass/patternfly-react/_modeless-overlay.scss

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,13 @@
66

77
.modal-content {
88
height: calc(100vh - #{$navbar-pf-height});
9+
display: flex;
10+
flex-direction: column;
11+
12+
.modal-body {
13+
flex-grow: 1;
14+
overflow: hidden auto;
15+
}
916
}
1017
}
1118

packages/patternfly-3/patternfly-react/src/components/Modal/__mocks__/mockModalManager.js

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,30 @@ export class MockModalManager extends React.Component {
4949
<input type="text" id="textInput3" className="form-control" />
5050
</div>
5151
</div>
52+
<div className="form-group">
53+
<label className="col-sm-3 control-label" htmlFor="textInput4">
54+
Field Four
55+
</label>
56+
<div className="col-sm-9">
57+
<input type="text" id="textInput3" className="form-control" />
58+
</div>
59+
</div>
60+
<div className="form-group">
61+
<label className="col-sm-3 control-label" htmlFor="textInput5">
62+
Field Five
63+
</label>
64+
<div className="col-sm-9">
65+
<input type="text" id="textInput3" className="form-control" />
66+
</div>
67+
</div>
68+
<div className="form-group">
69+
<label className="col-sm-3 control-label" htmlFor="textInput6">
70+
Field Six
71+
</label>
72+
<div className="col-sm-9">
73+
<input type="text" id="textInput3" className="form-control" />
74+
</div>
75+
</div>
5276
</form>
5377
);
5478

packages/patternfly-3/patternfly-react/src/components/ModelessOverlay/__mocks__/mockModelessManager.js

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,30 @@ export class MockModelessManager extends React.Component {
4343
<input type="text" id="textInput3" className="form-control" />
4444
</div>
4545
</div>
46+
<div className="form-group">
47+
<label className="col-sm-3 control-label" htmlFor="textInput4">
48+
Field Four
49+
</label>
50+
<div className="col-sm-9">
51+
<input type="text" id="textInput3" className="form-control" />
52+
</div>
53+
</div>
54+
<div className="form-group">
55+
<label className="col-sm-3 control-label" htmlFor="textInput5">
56+
Field Five
57+
</label>
58+
<div className="col-sm-9">
59+
<input type="text" id="textInput3" className="form-control" />
60+
</div>
61+
</div>
62+
<div className="form-group">
63+
<label className="col-sm-3 control-label" htmlFor="textInput6">
64+
Field Six
65+
</label>
66+
<div className="col-sm-9">
67+
<input type="text" id="textInput3" className="form-control" />
68+
</div>
69+
</div>
4670
</form>
4771
);
4872

0 commit comments

Comments
 (0)