Skip to content

Conversation

@dlabrecq
Copy link
Member

@dlabrecq dlabrecq commented Dec 8, 2018

This PR fixes an issue with the text property of BulletChartAxisTic.

The text property is documented, but never used in the code. It allows users to apply a custom label to the x-axis, while the given value property used by default.

Fixes #1028

@coveralls
Copy link

coveralls commented Dec 8, 2018

Pull Request Test Coverage Report for Build 3514

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 82.239%

Totals Coverage Status
Change from base Build 3512: 0.005%
Covered Lines: 3982
Relevant Lines: 4581

💛 - Coveralls

@dlabrecq dlabrecq force-pushed the 1028-BulletChartAxisTic branch from 37f03a2 to 545ec1d Compare December 8, 2018 19:30
@patternfly-build
Copy link
Collaborator

PatternFly-React preview: https://1029-pr-patternfly-react-patternfly.surge.sh

@dtaylor113 dtaylor113 merged commit 7e58ebf into patternfly:master Dec 11, 2018
@dlabrecq dlabrecq deleted the 1028-BulletChartAxisTic branch June 25, 2019 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BulletChart: Cannot set text for custom axis tic mark

5 participants