fix(DualList): fix hidden inputs #1207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
PatternFly-React preview: https://1207-pr-patternfly-react-patternfly.surge.sh |
Pull Request Test Coverage Report for Build 4027
💛 - Coveralls |
Ron-Lavi
force-pushed
the
fix/dual-list-hidden-inputs
branch
from
2eef4ac to
3f4c4d9
Compare
dtaylor113
approved these changes
Jan 17, 2019
jeff-phillips-18
approved these changes
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hidden inputs should reflect the whole list and not just the selected items.
The main idea of the dual list is to mimic the html select behavior into a prettier implementation
and when the consumers will choose that one side is the "selected-side", they will be able to send of all its items on submitting in a form for example.
this PR also fixes a test warning, and storybook error