Skip to content

Conversation

@boaz0
Copy link
Member

@boaz0 boaz0 commented Mar 22, 2019

What:

fix #1607
fix #1608

//cc @ibolton336

tlabaj
tlabaj previously approved these changes Mar 22, 2019
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
@codecov-io
Copy link

codecov-io commented Mar 24, 2019

Codecov Report

Merging #1627 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1627   +/-   ##
=======================================
  Coverage   82.89%   82.89%           
=======================================
  Files         573      573           
  Lines        6249     6249           
  Branches       75       75           
=======================================
  Hits         5180     5180           
  Misses       1039     1039           
  Partials       30       30
Flag Coverage Δ
#patternfly3 84.75% <ø> (ø) ⬆️
#patternfly4 79.58% <ø> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a466069...1db98c4. Read the comment docs.

@patternfly-build
Copy link
Collaborator

PatternFly-React preview: https://1627-pr-patternfly-react-patternfly.surge.sh

Copy link
Collaborator

@jschuler jschuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @boaz0

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit 0aa174d into patternfly:master Mar 27, 2019
@boaz0
Copy link
Member Author

boaz0 commented Mar 28, 2019

Thank you all 🕺

@boaz0 boaz0 deleted the fix_1608_07 branch March 28, 2019 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PF4 DataList: expanded should not be a required prop for DataListItem PF4 DataList: width is required?

6 participants