fix(DualList): add callbacks to Controlled Dual List methods #1901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
PatternFly-React preview: https://1901-pr-patternfly-react-patternfly.surge.sh |
Codecov Report
@@ Coverage Diff @@
## master #1901 +/- ##
==========================================
+ Coverage 82.63% 82.66% +0.03%
==========================================
Files 624 624
Lines 6875 6888 +13
Branches 93 93
==========================================
+ Hits 5681 5694 +13
Misses 1154 1154
Partials 40 40
Continue to review full report at Codecov.
|
Closed
13 tasks
Ron-Lavi
force-pushed
the
fix/dual_list_callbacks
branch
from
ad61965 to
5199245
Compare
jeff-phillips-18
previously approved these changes
May 2, 2019
| DualListControlled.propTypes = { | ||
| /** | ||
| * Function that runs after items have been moved between the lists. | ||
| * Recieves the updated state as a callback. |
Member
There was a problem hiding this comment.
nit: typo -> receives
(below as well)
dtaylor113
previously approved these changes
May 2, 2019
Ron-Lavi
force-pushed
the
fix/dual_list_callbacks
branch
from
5199245 to
22db98f
Compare
Collaborator
Author
|
Thanks, fixed :) |
Collaborator
Author
|
can we merge it? :) |
jeff-phillips-18
approved these changes
May 14, 2019
dtaylor113
approved these changes
May 15, 2019
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add callbacks of the updated state for each method in the controlled Dual List