Convert React-Table to TypeScript

[priley86]

• convert all react-table source to tsx
• bring the reactabular-table source in house and convert it to tsx. This follows along with PF4 Bring Reactabular in-house #1628 which I have already prototyped alongside W.I.P. React virtualized extension #1250, but I will pull that change out specifically alongside tsx conversion for now.

[priley86]

• noted will need to be able to share tsconfigs/base tslint configs with other packages outside of react-core to accomplish this.

[ssilvert]

Hi @priley86, do you have an ETA for this?

We are trying to use react-table with TypeScript and we get errors about declaration files. Also looks like you need to use the latest version of react-core.

node_modules/@patternfly/react-table/dist/js/components/Table/index.d.ts(20,49): error TS7016: Could not find a declaration file for module './ExpandableRowContent'. 'C:/GitHub/keycloak/themes/src/main/resources/theme/keycloak-preview/account/resources/node_modules/@patternfly/react-table/dist/js/components/Table/ExpandableRowContent.js' implicitly has an 'any' type.
node_modules/@patternfly/react-table/node_modules/@patternfly/react-core/dist/js/components/Select/Select.d.ts(10,18): error TS2430: Interface 'SelectProps' incorrectly extends interface 'HTMLProps'.
Types of property 'onSelect' are incompatible.
Type '(event: any, element: string, isPlaceholder: boolean) => void' is not assignable to type '(event: SyntheticEvent<HTMLOptionElement, Event>) => void'.
node_modules/@patternfly/react-table/node_modules/@patternfly/react-core/dist/js/components/Select/Select.d.ts(14,19): error TS2304: Cannot find name 'ReactEventHandler'.

[priley86]

hi @ssilvert 👋

i'm guessing we'll be able to introduce this in the next few sprints - currently still trying to resolve a few other things downstream on my side. I'll probably be able to attempt this next week though. As far as I can tell, we'll need Dropdown and a few other react-core components converted to TS first. Noted that when starting this here. If you need this sooner and would like to try and contribute it (or you have a short term workaround), happy to review this w/ you.

cc: @LHinson @dgutride @rachael-phillips