Skip to content

fix(HorizontalNav): Horizontal nav is not exported for build. #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dgutride merged 1 commit into from
May 20, 2019
Merged

fix(HorizontalNav): Horizontal nav is not exported for build. #2041

dgutride merged 1 commit into from
May 20, 2019

Conversation

@Hyperkid123
Copy link
Contributor

@Hyperkid123 Hyperkid123 commented May 20, 2019

fix #2040

What:
Added HorizontalNav to src/index in PF3

@patternfly-build
Copy link
Collaborator

patternfly-build commented May 20, 2019

PatternFly-React preview: https://2041-pr-patternfly-react-patternfly.surge.sh

@codecov-io
Copy link

codecov-io commented May 20, 2019 •
edited
Loading

Codecov Report

Merging #2041 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2041   +/-   ##
=======================================
  Coverage   81.85%   81.85%           
=======================================
  Files         628      628           
  Lines        7159     7159           
  Branches      250      250           
=======================================
  Hits         5860     5860           
  Misses       1164     1164           
  Partials      135      135
Flag Coverage Δ
#patternfly3 84.88% <ø> (ø) ⬆️
#patternfly4 77.87% <ø> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2e7cb5...9b9958f. Read the comment docs.

@martinpovolny
Copy link
Contributor

martinpovolny commented May 20, 2019 •
edited
Loading

I hit into that issue today trying to use the nested drop-down to reimplement ManageIQ toolbar kebabs in React (now in Angular).

Please, merge!

@martinpovolny
Copy link
Contributor

martinpovolny commented May 20, 2019

ping @jtomasek

@martinpovolny martinpovolny mentioned this pull request May 20, 2019
Merged
karelhala
karelhala approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@karelhala karelhala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

tlabaj
tlabaj approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgutride dgutride merged commit 2b04c04 into patternfly:master May 20, 2019
@Hyperkid123 Hyperkid123 deleted the expose-horizontal-nav branch May 21, 2019 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tlabaj tlabaj tlabaj approved these changes

+2 more reviewers

@karelhala karelhala karelhala approved these changes

@dgutride dgutride dgutride approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PF3 HorizontalNav is not exported for build

7 participants

@Hyperkid123 @patternfly-build @codecov-io @martinpovolny @karelhala @dgutride @tlabaj