feat(a11y): add basic a11y checks with react-axe #712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanforyou23
force-pushed
the
pf-react-axe
branch
from
b98ad19 to
5cb6347
Compare
Collaborator
|
PatternFly-React preview: https://712-pr-patternfly-react-patternfly.surge.sh |
Pull Request Test Coverage Report for Build 2400
💛 - Coveralls |
| const axe = require('react-axe'); // eslint-disable-line global-require | ||
| axe(React, ReactDOM, 1000); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
I'm not sure about adding this here as it could get included by consumers. What about adding it only to storybook in https://github.com/patternfly/patternfly-react/blob/master/storybook/config.js ?
Contributor
Author
There was a problem hiding this comment.
Ah good call, should have thought of that :)
jeff-phillips-18
approved these changes
Oct 5, 2018
dgutride
approved these changes
Oct 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #603
What: Adding automated accessibility checks for PF3 react components
Additional issues: #603
Is this the best place to install react-axe?
Here are some screenshots that shows what interacting with the tool looks like.