Skip to content

In some components innerRef prop is not hidden #8180

@dominik-petrik

Description

@dominik-petrik

Describe the problem
Some components have innerRef prop listed in props list even though it's prop of base component and should be hidden.

Which components are affected?

  • Button
  • MenuContent
  • MenuGroup
  • MenuInput
  • MenuItemAction
  • MenuToggle
  • SelectMenu
  • SerialConsole
  • Tab
  • TabContent
  • TextArea
  • TextInput
  • TextInputGroupMain
  • ToolbarGroup
  • LogViewer
  • TableComposable
  • Tbody
  • Thead
  • Xterm

In some components passing innerRef accidentally works when it probably should not. Fixing this could be a breaking change. These will be fixed in #8233:

  • BackToTop
  • MenuToggle
  • TextInputGroupMain (passing innerRef works while passing ref doesn't)

Expected behavior
innerRef prop should be hidden.

Metadata

Metadata

Assignees

Labels

Breaking change 💥this change requires a major release and has API changes.PF5

Type

No type

Projects

Status

Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions