fix(LoginPage): improve submit button UX #944
Conversation
|
PatternFly-React preview: https://944-pr-patternfly-react-patternfly.surge.sh |
Pull Request Test Coverage Report for Build 3298
💛 - Coveralls |
| showError, | ||
| attributes | ||
| attributes, | ||
| isLoading |
| {isLoading ? ( | ||
| <span> | ||
| {' '} | ||
| <Icon name="spinner" spin size="lg" /> |
There was a problem hiding this comment.
perhaps use the spinner component?
There was a problem hiding this comment.
Do we have one ? :O
There was a problem hiding this comment.
Here's a link to the PF3 react spinner (using your storybook preview url, btw)
Ron-Lavi
force-pushed
the
fix/login-page-on-submit
branch
from
15a06ea to
c7c04c3
Compare
jeff-phillips-18
left a comment
jeff-phillips-18
left a comment
There was a problem hiding this comment.
the propTypes should have comments to show up in the storybook descriptions. However, since none of the pre-existing loginPage components do, you can add them or add an issue to have them added in the future.
Please add tests for the LoginCardSubmitButton.
|
Thanks, I will polish the proptypes in another PR, |
|
@jeff-phillips-18 though it seems that |
|
I took a quick look, and don't see any issues from the html/css side. |
8 participants
As part of the LoginPage implementation in Foreman
Adding loading spinner and disable mode to the login submit button.