Convert demo application to Vite #10510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkoops
commented
Jun 3, 2024
| { | ||
| "files": ["packages/react-integration/demo-app-ts/**/*"], | ||
| "rules": { | ||
| "patternfly-react/no-anonymous-functions": "off", |
Contributor
Author
There was a problem hiding this comment.
This linting rule gives false positives for class components that already have a displayName, so I've turned this off. For example:
class MyComponent extends React.Component {
static displayName = "MyComponent"; // It doesn't like this.
}
jonkoops
commented
Jun 3, 2024
| "files": ["packages/react-integration/demo-app-ts/**/*"], | ||
| "rules": { | ||
| "patternfly-react/no-anonymous-functions": "off", | ||
| "react/react-in-jsx-scope": "off", |
Contributor
Author
There was a problem hiding this comment.
There is no need for this, as Vite uses the JSX transform.
jonkoops
commented
Jun 3, 2024
| "rules": { | ||
| "patternfly-react/no-anonymous-functions": "off", | ||
| "react/react-in-jsx-scope": "off", | ||
| "spaced-comment": "off" |
Contributor
Author
There was a problem hiding this comment.
This gives a false positive, so I've disabled it for now.
jonkoops
commented
Jun 3, 2024
| "start": "yarn build && concurrently --kill-others \"yarn watch\" \"yarn workspace @patternfly/react-docs develop\"", | ||
| "start:cypress": "lerna run cypress:open", | ||
| "start:demo-app": "lerna run start:demo-app --stream", | ||
| "start:demo-app:hot": "lerna run start:demo-app:hot --stream", |
Contributor
Author
There was a problem hiding this comment.
Hot reloading is default in Vite during development, so it is no longer needed to keep this separate script around.
Contributor
|
Preview: https://patternfly-react-pr-10510.surge.sh A11y report: https://patternfly-react-pr-10510-a11y.surge.sh |
jonkoops
commented
Jun 3, 2024
Contributor
Author
There was a problem hiding this comment.
This test never ran, so I removed it.
Signed-off-by: Jon Koops <jonkoops@gmail.com>
nicolethoen
approved these changes
Jun 4, 2024
kmcfaul
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces WebPack with Vite to build the demo app, this reduces the amount of dependencies and is also a faster and more consistent development experience. Works towards closing #7287