fix(build): get our custom TS transformers working again (v6) #10523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-10523.surge.sh A11y report: https://patternfly-react-pr-10523-a11y.surge.sh |
nicolethoen
approved these changes
Jun 6, 2024
tlabaj
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #10522
V6 version of #10477
Additional issues:
It seems that our custom TS transformers haven't been working, probably since the TS version bump.
This PR updates ts-patch (which gets them running again) and updates them to work with our current TS version.
To test pull this branch, do a build, and verify that the files in react-core/dist/js have their dist/esm import paths properly updated to dist/js. Compare to line seven of this dist/js file in our latest v5 prerelease where it's trying to import from the ESM build.