Skip to content

chore: use workspace: protocol for workspace dependencies #10549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2024
Merged

chore: use workspace: protocol for workspace dependencies #10549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions GETTING-STARTED.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,3 @@ PatternFly React has 3 linters you can run all at once using `yarn lint:all`. Th
### ESLint

ESLint is run on .js, .jsx, .ts, and .tsx files. It uses the [@typescript-eslint](https://github.com/typescript-eslint/typescript-eslint) parser with custom config added over the years. We write some of our own ESLint rules in `eslint-plugin-patternfly-react`. You can run this linter with `yarn lint:ts` or on specific files with `yarn lint <path>`.

### Version lint

The `@patternfly` version linter is run on all `package.json` files to ensure that versions of all `@patternfly/*` packages match. This is done to prevent mismatching versions of essential PatternFly packages from accidentally being published. You can run this linter with `yarn lint:versions`.
6 changes: 2 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,9 @@
"clean:exports": "lerna run clean:exports --parallel --stream",
"generate": "yarn plop",
"lint": "eslint --ext js,jsx,ts,tsx --cache --cache-strategy content",
"lint:all": "yarn lint:md && yarn lint:versions && yarn lint:ts",
"lint:all": "yarn lint:md && yarn lint:ts",
"lint:md": "yarn eslint packages --ext md --no-eslintrc --config .eslintrc-md.json --cache --cache-strategy content",
"lint:ts": "yarn lint packages/*/src",
"lint:versions": "node scripts/verifyPatternflyVersions.js",
"lint:tests": "yarn lint packages/*/src/components/*/__tests__/*.test.*",
"prepare": "ts-patch install -s",
"serve:docs": "yarn workspace @patternfly/react-docs serve",
Expand All @@ -113,8 +112,7 @@
},
"lint-staged": {
"*.md": "yarn lint:md --fix",
"*.{js,jsx,ts,tsx}": "yarn lint --fix",
"*.json": "yarn lint:versions --fix"
"*.{js,jsx,ts,tsx}": "yarn lint --fix"
},
"workspaces": {
"packages": [
Expand Down
4 changes: 2 additions & 2 deletions packages/react-charts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
},
"homepage": "https://github.com/patternfly/patternfly-react#readme",
"dependencies": {
"@patternfly/react-styles": "^5.4.0-prerelease.6",
"@patternfly/react-tokens": "^5.4.0-prerelease.5",
"@patternfly/react-styles": "workspace:^",
"@patternfly/react-tokens": "workspace:^",
"hoist-non-react-statics": "^3.3.2",
"lodash": "^4.17.21",
"tslib": "^2.6.3",
Expand Down
6 changes: 3 additions & 3 deletions packages/react-code-editor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@
},
"dependencies": {
"@monaco-editor/react": "^4.6.0",
"@patternfly/react-core": "^5.4.0-prerelease.15",
"@patternfly/react-icons": "^5.4.0-prerelease.5",
"@patternfly/react-styles": "^5.4.0-prerelease.6",
"@patternfly/react-core": "workspace:^",
"@patternfly/react-icons": "workspace:^",
"@patternfly/react-styles": "workspace:^",
"react-dropzone": "14.2.3",
"tslib": "^2.6.3"
},
Expand Down
6 changes: 3 additions & 3 deletions packages/react-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@
"clean:exports": "node scripts/cleanDistExports.js"
},
"dependencies": {
"@patternfly/react-icons": "^5.4.0-prerelease.5",
"@patternfly/react-styles": "^5.4.0-prerelease.6",
"@patternfly/react-tokens": "^5.4.0-prerelease.5",
"@patternfly/react-icons": "workspace:^",
"@patternfly/react-styles": "workspace:^",
"@patternfly/react-tokens": "workspace:^",
"focus-trap": "7.5.4",
"react-dropzone": "^14.2.3",
"tslib": "^2.6.3"
Expand Down
18 changes: 9 additions & 9 deletions packages/react-docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@
},
"dependencies": {
"@patternfly/patternfly": "5.4.0-prerelease.3",
"@patternfly/react-charts": "^7.4.0-prerelease.11",
"@patternfly/react-code-editor": "^5.4.0-prerelease.17",
"@patternfly/react-core": "^5.4.0-prerelease.15",
"@patternfly/react-drag-drop": "^5.4.0-prerelease.16",
"@patternfly/react-icons": "^5.4.0-prerelease.5",
"@patternfly/react-styles": "^5.4.0-prerelease.6",
"@patternfly/react-table": "^5.4.0-prerelease.16",
"@patternfly/react-templates": "^1.1.0-prerelease.15",
"@patternfly/react-tokens": "^5.4.0-prerelease.5"
"@patternfly/react-charts": "workspace:^",
"@patternfly/react-code-editor": "workspace:^",
"@patternfly/react-core": "workspace:^",
"@patternfly/react-drag-drop": "workspace:^",
"@patternfly/react-icons": "workspace:^",
"@patternfly/react-styles": "workspace:^",
"@patternfly/react-table": "workspace:^",
"@patternfly/react-templates": "workspace:^",
"@patternfly/react-tokens": "workspace:^"
},
"devDependencies": {
"@patternfly/documentation-framework": "^5.16.4",
Expand Down
6 changes: 3 additions & 3 deletions packages/react-drag-drop/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@
"@dnd-kit/core": "^6.1.0",
"@dnd-kit/modifiers": "^6.0.1",
"@dnd-kit/sortable": "^7.0.2",
"@patternfly/react-core": "^5.4.0-prerelease.15",
"@patternfly/react-icons": "^5.4.0-prerelease.5",
"@patternfly/react-styles": "^5.4.0-prerelease.6",
"@patternfly/react-core": "workspace:^",
"@patternfly/react-icons": "workspace:^",
"@patternfly/react-styles": "workspace:^",
"memoize-one": "^5.2.1",
"resize-observer-polyfill": "^1.5.1"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/react-integration/demo-app-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"preview": "vite preview --port 3000"
},
"dependencies": {
"@patternfly/react-core": "^5.4.0-prerelease.15",
"@patternfly/react-core": "workspace:^",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"react-router": "^5.3.4",
Expand Down
8 changes: 4 additions & 4 deletions packages/react-table/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@
"subpaths": "node ../../scripts/exportSubpaths.js --config subpaths.config.json"
},
"dependencies": {
"@patternfly/react-core": "^5.4.0-prerelease.15",
"@patternfly/react-icons": "^5.4.0-prerelease.5",
"@patternfly/react-styles": "^5.4.0-prerelease.6",
"@patternfly/react-tokens": "^5.4.0-prerelease.5",
"@patternfly/react-core": "workspace:^",
"@patternfly/react-icons": "workspace:^",
"@patternfly/react-styles": "workspace:^",
"@patternfly/react-tokens": "workspace:^",
"lodash": "^4.17.21",
"tslib": "^2.6.3"
},
Expand Down
8 changes: 4 additions & 4 deletions packages/react-templates/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@
"subpaths": "node ../../scripts/exportSubpaths.js --config subpaths.config.json"
},
"dependencies": {
"@patternfly/react-core": "^5.4.0-prerelease.15",
"@patternfly/react-icons": "^5.4.0-prerelease.5",
"@patternfly/react-styles": "^5.4.0-prerelease.6",
"@patternfly/react-tokens": "^5.4.0-prerelease.5",
"@patternfly/react-core": "workspace:^",
"@patternfly/react-icons": "workspace:^",
"@patternfly/react-styles": "workspace:^",
"@patternfly/react-tokens": "workspace:^",
"tslib": "^2.6.3"
},
"peerDependencies": {
Expand Down
75 changes: 0 additions & 75 deletions scripts/verifyPatternflyVersions.js
View file
Open in desktop

This file was deleted.

Loading