Skip to content

fix(Table): compound expansion table row styles #10602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix(Table): compound expansion table row styles #10602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/react-table/src/components/Table/Tr.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ export interface TrProps extends Omit<React.HTMLProps<HTMLTableRowElement>, 'onR
isStriped?: boolean;
/** Flag indicating the row will act as a border. This is typically used for a table with a nested and sticky header. */
isBorderRow?: boolean;
/** Flag indicating the row is controlling the expansion of another row. */
isControlRow?: boolean;
/** An event handler for the row */
onRowClick?: (event?: React.KeyboardEvent | React.MouseEvent) => void;
/** Flag indicating that the row is selectable */
Expand All @@ -50,6 +52,7 @@ const TrBase: React.FunctionComponent<TrProps> = ({
isRowSelected = false,
isStriped = false,
isBorderRow = false,
isControlRow = false,
innerRef,
ouiaId,
ouiaSafe = true,
Expand Down Expand Up @@ -100,6 +103,7 @@ const TrBase: React.FunctionComponent<TrProps> = ({
isRowSelected && styles.modifiers.selected,
isStriped && styles.modifiers.striped,
isBorderRow && styles.modifiers.borderRow,
isControlRow && styles.tableControlRow,
resetOffset && styles.modifiers.firstCellOffsetReset
)}
hidden={rowIsHidden}
Expand Down
2 changes: 1 addition & 1 deletion packages/react-table/src/components/Table/examples/TableCompoundExpandable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export const TableCompoundExpandable: React.FunctionComponent = () => {
const isRowExpanded = !!expandedCellKey;
return (
<Tbody key={repo.name} isExpanded={isRowExpanded}>
<Tr>
<Tr isControlRow>
<Td width={25} dataLabel={columnNames.name} component="th">
<a href="#">{repo.name}</a>
</Td>
Expand Down