fix(SimpleSelect,CheckboxSelect): Handle initial selection(s) #10734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-phillips-18
requested review from
jenny-s51,
kmcfaul,
nicolethoen and
tlabaj
Contributor
|
Preview: https://patternfly-react-pr-10734.surge.sh A11y report: https://patternfly-react-pr-10734-a11y.surge.sh |
jenny-s51
approved these changes
Jul 15, 2024
Contributor
jenny-s51
left a comment
jenny-s51
left a comment
There was a problem hiding this comment.
LGTM, CheckboxSelect and SimpleSelect support and display initial selections, onSelect functionality works as expected
dlabaj
approved these changes
Jul 15, 2024
Contributor
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
tlabaj
pushed a commit
to tlabaj/patternfly-react
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Closes #10732
Description:
Handle initial selected options and options that get updated.