Skip to content

Conversation

@kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Jul 15, 2024

What: Closes #10664

Updates docs to clarify edge cases where additional configuration and webpack plugins may be required, as monaco-editor is not bundled with react-code-editor.

@kmcfaul
Copy link
Contributor Author

kmcfaul commented Jul 15, 2024

cc @christianvogt

@patternfly-build
Copy link
Contributor

patternfly-build commented Jul 15, 2024

@tlabaj tlabaj requested a review from nicolethoen July 15, 2024 20:48
Copy link
Contributor

@dlabaj dlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlabaj dlabaj merged commit 98cd2fb into patternfly:main Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug - [CodeEditor] - loads files from CDN instead of node_modules

4 participants