feat(MultiTypeaheadSelect): Add MultiTypeaheadSelect to react-templates #10757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-phillips-18
requested review from
dlabaj,
jenny-s51,
kmcfaul and
nicolethoen
Contributor
|
Preview: https://patternfly-react-pr-10757.surge.sh A11y report: https://patternfly-react-pr-10757-a11y.surge.sh |
jeff-phillips-18
force-pushed
the
multi-typeahead-select
branch
from
6a8dd11 to
2e41794
Compare
jeff-phillips-18
force-pushed
the
multi-typeahead-select
branch
from
2e41794 to
ccf4280
Compare
tlabaj
requested changes
Jul 17, 2024
| const [activeItemId, setActiveItemId] = React.useState<string | null>(null); | ||
| const textInputRef = React.useRef<HTMLInputElement>(); | ||
|
|
||
| const NO_RESULTS = 'no results'; |
Contributor
There was a problem hiding this comment.
Can we add a prop so consumers an change this string?
Contributor
There was a problem hiding this comment.
Never mind. It looks like that is not a display string.
dlabaj
approved these changes
Jul 17, 2024
Contributor
dlabaj
left a comment
dlabaj
left a comment
There was a problem hiding this comment.
Other then titani's comment LGTM.
tlabaj
approved these changes
Jul 17, 2024
kmcfaul
requested changes
Jul 17, 2024
Contributor
kmcfaul
left a comment
kmcfaul
left a comment
There was a problem hiding this comment.
Just one behavioral bug, everything else lgtm
kmcfaul
reviewed
Jul 17, 2024
packages/react-templates/src/components/Select/MultiTypeaheadSelect.tsx
Outdated
Show resolved
Hide resolved
…elect.tsx Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com>
jenny-s51
approved these changes
Jul 17, 2024
kmcfaul
approved these changes
Jul 17, 2024
Contributor
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
tlabaj
added a commit
to tlabaj/patternfly-react
that referenced
this pull request
Jul 31, 2024
…es (patternfly#10757) * feat(MultiTypeaheadSelect): Add MultiTypeaheadSelect to react-templates * Update packages/react-templates/src/components/Select/MultiTypeaheadSelect.tsx Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com> --------- Co-authored-by: Titani Labaj <39532947+tlabaj@users.noreply.github.com> Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com>
kmcfaul
added a commit
that referenced
this pull request
Aug 8, 2024
* fix(TypeaheadSelect): Add callback on clear selection (#10719) * fix(CodeEditor) resizeObserver resize loop (#10644) * fix(CodeEditor) resizeObserver resize loop * yarn * add debounce --------- Co-authored-by: Titani <tlabaj@redhat.com> * cherry pick fix(SimpleSelect,CheckboxSelect): Handle initial selection(s) * (Drag and drop): Updated example for multi list to use flex * docs(Table): add Editable Table example * fix(DragDrop): fix flexgrow type * feat(MultiTypeaheadSelect): Add MultiTypeaheadSelect to react-templates (#10757) * feat(MultiTypeaheadSelect): Add MultiTypeaheadSelect to react-templates * Update packages/react-templates/src/components/Select/MultiTypeaheadSelect.tsx Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com> --------- Co-authored-by: Titani Labaj <39532947+tlabaj@users.noreply.github.com> Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com> * fix(TypeaheadSelect): Correctly show the newly selected item on selection (#10792) * feat(TypeaheadSelect) Add creation options to TypeaheadSelect (#10802) * update MultiTypeaheadSelect to use label instead of chip * chore(deps): upgrade eslint-plugin-react to the latest (#10739) * chore(deps): upgrade `eslint-plugin-markdown` to the latest version (#10738) Signed-off-by: Jon Koops <jonkoops@gmail.com> * resolve merge conflicts * feat(eslint-plugin-patternfly-react): update rules for eslint v9 (#10743) * resolve conflicts for chore(deps): upgrade ESLint to the latest version * fix yarn lint issue * fix yarn lint issue * fix(TypeaheadSelect): Update input value only when appropriate (#10826) * fix lint errors and demo-app --------- Signed-off-by: Jon Koops <jonkoops@gmail.com> Co-authored-by: Jeff Phillips <jephilli@redhat.com> Co-authored-by: Dominik Petřík <77832970+Dominik-Petrik@users.noreply.github.com> Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com> Co-authored-by: Jon Koops <jonkoops@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Closes #10733
Description:
Adds a
MultiTypeaheadSelectcomponent to the @patternfly/react-templates package and a demo of the component for the docs apge.