Skip to content

fix: 🐛 Tooltip: clean up timeouts on unmount to prevent warning #5991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2021
Merged

fix: 🐛 Tooltip: clean up timeouts on unmount to prevent warning #5991

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions packages/react-core/src/components/Tooltip/Tooltip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,23 @@ export const Tooltip: React.FunctionComponent<TooltipProps> = ({
const transitionTimerRef = React.useRef(null);
const showTimerRef = React.useRef(null);
const hideTimerRef = React.useRef(null);

const clearTimeouts = (timeoutRefs: React.RefObject<any>[]) => {
timeoutRefs.forEach(ref => {
if (ref.current) {
clearTimeout(ref.current);
}
});
};

// Cancel all timers on unmount
React.useEffect(
() => () => {
clearTimeouts([transitionTimerRef, hideTimerRef, showTimerRef]);
},
[]
);

const onDocumentKeyDown = (event: KeyboardEvent) => {
if (!triggerManually) {
if (event.keyCode === KEY_CODES.ESCAPE_KEY && visible) {
Expand All @@ -167,21 +184,14 @@ export const Tooltip: React.FunctionComponent<TooltipProps> = ({
}
}, [isVisible]);
const show = () => {
if (transitionTimerRef.current) {
clearTimeout(transitionTimerRef.current);
}
if (hideTimerRef.current) {
clearTimeout(hideTimerRef.current);
}
clearTimeouts([transitionTimerRef, hideTimerRef]);
showTimerRef.current = setTimeout(() => {
setVisible(true);
setOpacity(1);
}, entryDelay);
};
const hide = () => {
if (showTimerRef.current) {
clearTimeout(showTimerRef.current);
}
clearTimeouts([showTimerRef]);
hideTimerRef.current = setTimeout(() => {
setOpacity(0);
transitionTimerRef.current = setTimeout(() => setVisible(false), animationDuration);
Expand Down