Skip to content

Conversation

@andyyvo
Copy link
Contributor

@andyyvo andyyvo commented Jul 25, 2022

What: Closes #7687 . Tooltip test revamps WIP

Additional issues:

  • Kept TooltipArrow and TooltipContent tests in the main Tooltip test page
    • Used TooltipContent to test content prop
  • Could not test enableFlip
    • Is there a support for scrolling on RTL?
  • Could not test entryDelay and exitDelay
    • Styling for transition read as "opacity 300ms cubic-bezier(.54, 1.5, .38, 1.11) 0ms"
    • Changing the delay did not change the last numeric value which should be transition-delay
  • Could not test appendTo
  • Could not test maxWidth
  • Could not test distance
  • Could not test aria
  • Could not test flippedBehavior
  • Could not test id
  • Could not test reference

@patternfly-build
Copy link
Contributor

patternfly-build commented Jul 25, 2022

@nicolethoen nicolethoen requested a review from jpuzz0 July 25, 2022 18:55
@andyyvo andyyvo marked this pull request as draft July 27, 2022 14:47
@andyyvo
Copy link
Contributor Author

andyyvo commented Aug 22, 2022

Tests that I am still in the process of writing (not sure if all are possible):

[ ] entryDelay
[ ] exitDelay
[ ] appendTo
[ ] aria
[ ] id
[ ] reference
[ ] aria-live
[ ] animationDuration

@stale
Copy link

stale bot commented Oct 22, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Oct 22, 2022
@stale stale bot closed this Nov 5, 2022
@tlabaj tlabaj reopened this Dec 13, 2022
@stale stale bot removed the wontfix label Dec 13, 2022
@tlabaj tlabaj added the Pinned label Dec 13, 2022
@jpuzz0 jpuzz0 removed their request for review March 23, 2023 14:49
@thatblindgeye thatblindgeye self-assigned this Jun 16, 2023
@thatblindgeye
Copy link
Contributor

Closing in favor of #9295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tooltip test revamp

4 participants