chore(packages): removed extensions from monorepo #8488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-8488.surge.sh A11y report: https://patternfly-react-pr-8488-a11y.surge.sh |
jenny-s51
approved these changes
Jan 5, 2023
Contributor
jenny-s51
left a comment
jenny-s51
left a comment
There was a problem hiding this comment.
LGTM, no issues building demo app or PF website following these updates
Member
|
@nicolethoen When is the plan to merge this? Are we waiting until we have releasable repos for the extensions? |
Contributor
Author
|
@jeff-phillips-18 this is going to be merged into the v5 branch, so the v5 branch will exist until we are ready for the major release in june. Topology will still be on the main branch for now. Though, since we will be feature frozen on January 19th, we will want to open a similar PR on the main branch to remove topology before that day |
jenny-s51
pushed a commit
to jenny-s51/patternfly-react
that referenced
this pull request
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #8487