Skip to content

Conversation

@edonehoo
Copy link
Contributor

@edonehoo edonehoo commented Jan 6, 2023

Makes progress on patternfly/patternfly-org#2990

@edonehoo edonehoo changed the title Iss2990 menutoggle Adds content to menutoggle component examples. Jan 6, 2023
@patternfly-build
Copy link
Contributor

patternfly-build commented Jan 6, 2023

@edonehoo edonehoo changed the base branch from v5 to main January 6, 2023 16:50
@edonehoo edonehoo changed the title Adds content to menutoggle component examples. Adds content to menu toggle component examples. Jan 6, 2023
@edonehoo edonehoo self-assigned this Jan 9, 2023
@nicolethoen nicolethoen changed the base branch from main to v5 February 16, 2023 15:20
@nicolethoen
Copy link
Contributor

@edonehoo i'm noticing that the split menu toggle with secondary styling has been removed from the docs. was that a deliberate choice?

@edonehoo
Copy link
Contributor Author

edonehoo commented Feb 16, 2023

So I was proposing the idea of removing it, but let me know what you think. My reasoning was that maybe the "Variant styles" example (formerly primary toggles) demonstrated the variant options that can be used, but if we want to be more explicit about secondary split button toggles (and/or secondary toggles, which I also removed) then I can add it back in. I like simplifying, but don't want to over-simplify!

@nicolethoen
Copy link
Contributor

Would it be helpful/clear enough to add a row of toggles with secondary style below the row of toggles with primary style - all in the same example?

@edonehoo
Copy link
Contributor Author

I think that approach would work! Or an "isSecondary" toggle checkbox? I could add to the example content to point out both primary and secondary variants are shown in the example - if we wanted to be sure it's clear.

@nicolethoen
Copy link
Contributor

@edonehoo I made a few updates to rearrange the example code a little. WDYT?

Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples are looking good!

Regarding the convo about showing the different variants with split button examples, I think either approach could work (showing split button with the variants vs just mentioning that in the description). Since currently the split examples show the primary and secondary variant, we should probably also update the "Split button toggle with checkbox" example to match as well (instead of showing the disabled/collapsed/expanded states). The "Variant styling can be applied to split button toggles..." verbiage could then be moved to that example instead of the "Split button with text label" example.

@tlabaj tlabaj requested a review from mcarrano March 3, 2023 20:47
Copy link
Member

@mcarrano mcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @edonehoo !

import { MenuToggle, TextInputGroup, TextInputGroupMain, TextInputGroupUtilities, Button } from '@patternfly/react-core';
import TimesIcon from '@patternfly/react-icons/dist/esm/icons/times-icon';

export const Typeahead: React.FunctionComponent = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename this to MenuToggleTypeahead for consistency.

@nicolethoen nicolethoen requested a review from tlabaj March 13, 2023 18:20
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Erin! LGTM

@tlabaj tlabaj merged commit f920db4 into patternfly:v5 Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants