fix(SkipToContent): Updated markup #8650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-8650.surge.sh A11y report: https://patternfly-react-pr-8650-a11y.surge.sh |
thatblindgeye
approved these changes
Feb 6, 2023
kmcfaul
approved these changes
Feb 6, 2023
gitdallas
approved these changes
Feb 7, 2023
tlabaj
reviewed
Feb 15, 2023
packages/react-core/src/components/SkipToContent/SkipToContent.tsx
Outdated
Show resolved
Hide resolved
mcoker
reviewed
Feb 15, 2023
Contributor
mcoker
left a comment
mcoker
left a comment
There was a problem hiding this comment.
LGTM - a question about using the button component. Also there is a show prop that says it's used for demo purposes - do we have a use case for that or could we remove it?
packages/react-core/src/components/SkipToContent/SkipToContent.tsx
Outdated
Show resolved
Hide resolved
thatblindgeye
approved these changes
Feb 21, 2023
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Just a snapshot update/and a linting error that needs to be resolved, otherwise looks good
mcoker
approved these changes
Feb 22, 2023
Contributor
mcoker
left a comment
mcoker
left a comment
There was a problem hiding this comment.
LGTM other than the linting
| ...props | ||
| }: SkipToContentProps) => ( | ||
| <div className={css(styles.skipToContent, className)} {...props}> | ||
| <Button variant={ButtonVariant.primary} component='a' href={href}> |
Contributor
There was a problem hiding this comment.
Suggested change
| <Button variant={ButtonVariant.primary} component='a' href={href}> | |
| <Button variant={ButtonVariant.primary} component="a" href={href}> |
nicolethoen
force-pushed
the
skip_to_content_update
branch
from
5240ce4 to
1e24b1f
Compare
Contributor
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #8260
Moves the
pf-c-skip-to-contentclass off of theButtonand onto a div wrapping theButton.