Fix type definition for ContextSelectorItemProps
#8670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-8670.surge.sh A11y report: https://patternfly-react-pr-8670-a11y.surge.sh |
Contributor
Author
|
For reference, this was causing issues for us when extending the component and re-using this interface. |
tlabaj
previously approved these changes
Feb 13, 2023
Contributor
|
@jonkoops can this be against the v5 branch? |
Contributor
Author
|
@tlabaj Done 👍 |
Contributor
|
Can you run |
Contributor
Author
|
Done. Out of curiosity, how is this related to the change I made here? 🤔 Edit Looking at the commits this seems to have regressed on the |
tlabaj
approved these changes
Feb 21, 2023
Contributor
Author
|
@tlabaj I've rebased the PR so there is no longer a merge conflict, could you merge it in? |
Contributor
|
The linting issue in your PR has been fixed so a rebase should fix it. |
Contributor
Author
|
Rebased it another time, hopefully it's good now. |
nicolethoen
approved these changes
Mar 7, 2023
1 task
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the type definition of
ContextSelectorItemPropsso that theonClick,indexandsendRefprops are no longer required. Default values are already provided for these props, so this type was simply wrong.