fix(MenuGroup): do not set id when titleId prop isn't passed #8675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove default titleId prop value, so id is not being set everytime closes patternfly#8162 BREAKING CHANGE
Contributor
|
Preview: https://patternfly-react-pr-8675.surge.sh A11y report: https://patternfly-react-pr-8675-a11y.surge.sh |
Contributor
Author
|
Hi all, this is my first PR. I am not sure, whether I should have opened this PR against the There is also a lint error, I forgot to update the version in |
Contributor
Author
|
Also, I don't have a permission to assign reviewers of PR. If anybody can help, that'd be great :) |
jenny-s51
approved these changes
Feb 14, 2023
Contributor
jenny-s51
left a comment
jenny-s51
left a comment
There was a problem hiding this comment.
LGTM @adamviktora - nice work on your first PF contribution! 👏
gitdallas
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove default titleId prop value, so id is not being set everytime
closes #8162
BREAKING CHANGE
#8162
https://www.patternfly.org/v4/components/menu#titled-groups-of-items