feat(FormContext): Add context for Form to manage input state #8716
Conversation
| "scripts": { | ||
| "build:umd": "rollup -c --environment IS_PRODUCTION", | ||
| "clean": "rimraf dist", | ||
| "clean": "rimraf dist components layouts helpers next deprecated node_modules", |
There was a problem hiding this comment.
This does not pertain to this exact change, but something noticed when running clean, I believe these built sub-directories should be included.
| "analyze": "yarn build:docs --analyze", | ||
| "build:docs": "pf-docs-framework build all", | ||
| "clean": "rimraf .cache public static/assets static/base.css src/generated/**/*.js", | ||
| "clean": "rimraf .cache public static/assets static/base.css src/generated/**/*.js node_modules", |
There was a problem hiding this comment.
When using a local version of the documentation-framework, it helps to clear out these node_modules, as sometimes not doing so leads to false-positives/negatives.
| 'FormFieldGroupHeader', | ||
| 'FormFieldGroupHeaderTitleTextObject', | ||
| 'FormContextProps', | ||
| 'FormContextProviderProps', |
There was a problem hiding this comment.
Both of these types should probably be marked as beta, but there is no way to do so yet with the PF documentation-framework. The only use-case is an example called FormState, which is marked as beta, so hopefully that will suffice for now.
|
Preview: https://patternfly-react-pr-8716.surge.sh A11y report: https://patternfly-react-pr-8716-a11y.surge.sh |
jpuzz0
force-pushed
the
feature/form-context
branch
2 times, most recently
from
bb7f81c to
0b95e06
Compare
wise-king-sullyman
left a comment
wise-king-sullyman
left a comment
There was a problem hiding this comment.
Neat! I just have a couple small nit things and one test I'm not sure about.
packages/react-core/src/components/Form/__tests__/FormContext.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/Form/__tests__/FormContext.test.tsx
Outdated
Show resolved
Hide resolved
jpuzz0
force-pushed
the
feature/form-context
branch
from
7b7e044 to
c606f44
Compare
kmcfaul
left a comment
kmcfaul
left a comment
There was a problem hiding this comment.
lgtm just needs a rebase
jpuzz0
force-pushed
the
feature/form-context
branch
from
c606f44 to
5afe1fb
Compare
|
Github wont let me merge this because it says there are still conflicts needing to be resolved? |
jpuzz0
force-pushed
the
feature/form-context
branch
from
c923234 to
a0aa692
Compare
Yeah, looks like another PR merged today led to another conflict. I rebased and resolved that conflict just now. |
5 participants
What: Closes #7507