fix(Chip/Label): update structure to work with core updates #8773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-8773.surge.sh A11y report: https://patternfly-react-pr-8773-a11y.surge.sh |
thatblindgeye
requested changes
Mar 3, 2023
Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
thatblindgeye
approved these changes
Mar 3, 2023
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
I wouldn't block over an example for customBtn prop. If you decide to add one I'll re-review, though.
wise-king-sullyman
approved these changes
Mar 3, 2023
Contributor
wise-king-sullyman
left a comment
wise-king-sullyman
left a comment
There was a problem hiding this comment.
LGTM, one non blocking nit:
tlabaj
reviewed
Mar 3, 2023
Contributor
tlabaj
left a comment
tlabaj
left a comment
There was a problem hiding this comment.
lgtm other than suggestion Austin made.
tlabaj
approved these changes
Mar 3, 2023
mcoker
requested changes
Mar 3, 2023
Contributor
mcoker
left a comment
mcoker
left a comment
There was a problem hiding this comment.
Just one thing - looks like the overflow chip is its own thing and needs styles.chipContent around the text, too -
Contributor
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #8454