fix(Popover): Refactor popover header #8774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-8774.surge.sh A11y report: https://patternfly-react-pr-8774-a11y.surge.sh |
thatblindgeye
requested changes
Mar 3, 2023
added 2 commits
March 3, 2023 10:42
gitdallas
approved these changes
Mar 3, 2023
mcoker
reviewed
Mar 3, 2023
| <header className={css(styles.popoverHeader, className)} {...props}> | ||
| <div className={css(styles.popoverTitle)}> | ||
| {icon && <PopoverHeaderIcon>{icon}</PopoverHeaderIcon>} | ||
| <PopoverHeaderText headingLevel={titleHeadingLevel} id={id}> |
Contributor
There was a problem hiding this comment.
This is fine but should it be <PopoverHeaderTitleText>? That will match the core class. It's named that way to try and avoid naming conflicts if we introduce something like a subtitle in the header.
mcoker
requested changes
Mar 3, 2023
Contributor
mcoker
left a comment
mcoker
left a comment
There was a problem hiding this comment.
Looks like the id was moved to the title text element - it should go on the title element instead. Otherwise lgtm!
added 3 commits
March 3, 2023 15:28
thatblindgeye
approved these changes
Mar 3, 2023
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
mcoker
approved these changes
Mar 3, 2023
nicolethoen
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #8456