Skip to content

fix(test): update script #8791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 9, 2023
Merged

fix(test): update script #8791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14c1f5f
fix(test): update script
nicolethoen Mar 8, 2023
bb2f5cc
update node engine in package.json
nicolethoen Mar 8, 2023
0960b54
update contribution guide
nicolethoen Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"url": "https://github.com/patternfly/patternfly-react.git"
},
"engines": {
"node": ">=14.0.0",
"node": ">=18.0.0",
"yarn": ">=1.6.0"
},
"keywords": [
Expand Down Expand Up @@ -90,7 +90,7 @@
"start:cypress": "lerna run cypress:open",
"start:demo-app": "lerna run start:demo-app --stream",
"start:demo-app:hot": "lerna run start:demo-app:hot --stream",
"test": "TZ=EST jest packages",
"test": "TZ=EST LC_ALL=en_US.UTF8 jest packages",
"test:a11y": "lerna run test:a11y --stream",
"test:integration": "yarn workspace @patternfly/react-integration test:integration",
"uninstall": "find . -name node_modules -type d | xargs rm -rf",
Expand Down
13 changes: 12 additions & 1 deletion packages/react-core/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,18 @@ $ git checkout -b my-branch -t upstream/main
ComponentName.md - Component Docs
```

4. Develop your component. After development is complete, ensure tests and lint standards pass.
4. Develop your component.
Copy link
Contributor

@tlabaj tlabaj Mar 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


While developing, you can run the patternfly-react workspace to view the component docs with live examples.

**Note:** Be sure you are using node version >= 18.0.0

```bash
# Start up the workspace locally on port 8002
yarn install && yarn start
```

5. After development is complete, ensure tests and lint standards pass.

```text
$ yarn test
Expand Down