Skip to content

docs full page mastheads toolbar formatting fix #8826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2023
Merged

docs full page mastheads toolbar formatting fix #8826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/react-core/src/demos/NotificationDrawer/NotificationDrawer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ class BasicNotificationDrawer extends React.Component {
</DropdownGroup>
];
const headerToolbar = (
<Toolbar>
<Toolbar isFullHeight>
Copy link
Contributor

@nicolethoen nicolethoen Mar 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the Dropdowns themselves also need the isFullHeight modifier on them to make the height of the user dropdowns consistent between examples

Copy link
Contributor

@nicolethoen nicolethoen Mar 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's like line 874

Copy link
Contributor Author

@MariaAga MariaAga Mar 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does look to make any visual change and 7/12 examples for username dont have that (searched for ned username and john smith) so should we change all example to have it or remove it from existing examples?

Copy link
Contributor

@nicolethoen nicolethoen Mar 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcarrano
Should the user dropdown in mastheads in our demos always be full height? Looks like in the react workspace right now, only half of them are full height.

Copy link
Member

@mcarrano mcarrano Mar 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I believe so, i.e. when they are open, the selected highlight is at the bottom of the masthead.

Copy link
Contributor Author

@MariaAga MariaAga Mar 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, I also counted the examples for pageHeader.
Added isFullHeight

<ToolbarContent>
<ToolbarGroup spaceItems={{ default: 'spacerNone' }} align={{ default: 'alignRight' }}>
<ToolbarGroup variant="icon-button-group">
Expand Down Expand Up @@ -293,6 +293,7 @@ class BasicNotificationDrawer extends React.Component {
position="right"
onSelect={this.onDropdownSelect}
isOpen={isDropdownOpen}
isFullHeight
toggle={
<DropdownToggle icon={<Avatar src={imgAvatar} alt="Avatar" />} onToggle={this.onDropdownToggle}>
John Smith
Expand Down Expand Up @@ -832,7 +833,7 @@ class GroupedNotificationDrawer extends React.Component {
</DropdownGroup>
];
const headerToolbar = (
<Toolbar>
<Toolbar isFullHeight>
<ToolbarContent>
<ToolbarGroup spaceItems={{ default: 'spacerNone' }} align={{ default: 'alignRight' }}>
<ToolbarGroup variant="icon-button-group">
Expand Down Expand Up @@ -887,6 +888,7 @@ class GroupedNotificationDrawer extends React.Component {
position="right"
onSelect={this.onDropdownSelect}
isOpen={isDropdownOpen}
isFullHeight
toggle={
<DropdownToggle icon={<Avatar src={imgAvatar} alt="Avatar" />} onToggle={this.onDropdownToggle}>
John Smith
Expand Down
15 changes: 9 additions & 6 deletions packages/react-core/src/demos/examples/AlertGroup/AlertGroupToastWithNotificationDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ import {
Alert,
AlertProps,
AlertGroup,
AlertActionCloseButton
AlertActionCloseButton,
ToolbarItem,
} from '@patternfly/react-core';

import SearchIcon from '@patternfly/react-icons/dist/js/icons/search-icon';
Expand Down Expand Up @@ -206,11 +207,13 @@ export const AlertGroupToastWithNotificationDrawer: React.FunctionComponent = ()
const alertButtonStyle = { marginRight: '8px', marginTop: '8px' };

const notificationBadge = (
<NotificationBadge
variant={getNotificationBadgeVariant()}
onClick={onNotificationBadgeClick}
aria-label="Notifications"
></NotificationBadge>
<ToolbarItem>
<NotificationBadge
variant={getNotificationBadgeVariant()}
onClick={onNotificationBadgeClick}
aria-label="Notifications"
></NotificationBadge>
</ToolbarItem>
);

const notificationDrawerActions = [
Expand Down