Skip to content

Conversation

@mcarrano
Copy link
Member

@mcarrano mcarrano commented Mar 17, 2023

Reorganizes items it the workspace towards improved findability on patternfly.org. Tertiary expandable navigation is now used to group items in the component nav. A new "Patterns" section is introduced to replace Demos. Specific changes include the following:

  • Group Date and Time related components together in the Components navigation.
  • Move menu related components into a group named "Menus"
  • Move form related components into a group names "Forms."
  • Group File Upload and File-Upload multiple into a new group named File Upload and rename components to Simple and Multiple File upload.
  • Move password strength, password generator, and composable menu demos to Components and rename Demos section to Patterns where the remaining full page demos can live.

Closes #8777

@patternfly-build
Copy link
Contributor

patternfly-build commented Mar 17, 2023

@mcarrano mcarrano marked this pull request as ready for review March 21, 2023 20:28
@mcarrano
Copy link
Member Author

@nicolethoen @tlabaj @evwilkin these changes in the React repo are now ready for review.

@evwilkin
Copy link
Member

@mcarrano it looks like the "File upload - multiple" demo needs to be updated similar to the examples file you've already changed, as it isn't grouped within the new "File upload" subsection

Also for @tlabaj - for the components renamed in the navigation (File upload => Simple file upload, File upload - multiple => Multiple file upload) should we also rename the exported components in the code? I ask because this would require follow-up React issues to change the name, along with codemods to update imports & usages for consumers. Or do you think going to "Simple file upload" to view docs for the "File upload" component makes sense - these would be the only 2 component docs to not match the component names in that case.

@nicolethoen
Copy link
Contributor

rename the exported components in the code

I believe we were not going to do that at this time. We were renaming the documentation for clarity, but leaving actual exported component names as they were. @tlabaj was that your understanding?

@tlabaj
Copy link
Contributor

tlabaj commented Mar 23, 2023

rename the exported components in the code

I believe we were not going to do that at this time. We were renaming the documentation for clarity, but leaving actual exported component names as they were. @tlabaj was that your understanding?

Yes, I thought we agreed to leave component names as is.

@evwilkin
Copy link
Member

@tlabaj @nicolethoen thanks!

@mcarrano this looks good with your last update to move that demo, it just looks like there are 2 merge conflicts that need to be resolved before we're able to merge.

@mcarrano
Copy link
Member Author

@evwilkin I believe that the two conflicts are because those components got deprecated after I opened this branch and moved to the /deprecated folder. Does that make sense? How do I fix that?

Copy link
Member

@evwilkin evwilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@evwilkin evwilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... Specific changes include the following:

  • Group Date and Time related components together in the Components navigation.

Should Calander month be included in with these

  • Move menu related components into a group named "Menus"

I only see one tab in Dropdown. I should see the "React Deprecated as well.

@mcarrano
Copy link
Member Author

@tlabaj Good catch regarding Calendar Month. I will move that to Date and Time. The other issue was fixed with my last commit.

@mcarrano
Copy link
Member Author

@evwilkin @nicolethoen @tlabaj Moved Calendar month to Date & Time. Please give a final review. Thanks.

@nicolethoen
Copy link
Contributor

nicolethoen commented Mar 24, 2023

Should we move Timestamp into the Date and time section while we are doing this?

@mcarrano
Copy link
Member Author

Should we move Timestamp into the Date and time section while we are doing this?

@evwilkin and @tlabaj what do you think?

@tlabaj
Copy link
Contributor

tlabaj commented Mar 24, 2023

Should we move Timestamp into the Date and time section while we are doing this?

Calendar month is used in the Date and time picker demos and that is why I called that one out to be moved. The timestamp is really independent of what is currently under the "Date and time picker" Nav item. Given the name of the Nav item, I don't know that I would look for it there.

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit 97cb551 into patternfly:v5 Mar 27, 2023
@mcarrano mcarrano deleted the v5-ia-updates branch April 6, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workspace - move pages per v5 website IA

5 participants