feat(Table): allow action tooltip #8838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-8838.surge.sh A11y report: https://patternfly-react-pr-8838-a11y.surge.sh |
gitdallas
approved these changes
Mar 22, 2023
Contributor
|
for reviewers' quick reference: https://patternfly-react-pr-8838.surge.sh/components/table#composable-actions
|
wise-king-sullyman
approved these changes
Mar 23, 2023
nicolethoen
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #8709
Adds
tooltipandtooltipPropstoIActionandActionsColumnto match the old Dropdown's functionality for tooltip use. Kept theisSeparatorflag as that was not a flag for the dropdown specifically but for the ActionsColumn to render a divider.We could probably refactor ActionsColumn to more directly use
Menuor Dropdown-next instead of passing data and mapping that to the components if we wanted, but I kept the API the same for now.