Skip to content

Conversation

@tlabaj
Copy link
Contributor

@tlabaj tlabaj commented Mar 21, 2023

What: towards #8003

@patternfly-build
Copy link
Contributor

patternfly-build commented Mar 21, 2023

@nicolethoen
Copy link
Contributor

Do you know what the babel plugin is used for?

@wise-king-sullyman
Copy link
Contributor

I'm also curious about that. It seems like we use it for transpiling jsx/tsx for Jest, and set the babel parser as the parser in the eslint-plugin-pf-react, but I don't see any other uses of it in the repo?

@tlabaj
Copy link
Contributor Author

tlabaj commented Mar 23, 2023

Do you know what the babel plugin is used for?

@nicolethoen Which one?

@tlabaj
Copy link
Contributor Author

tlabaj commented Mar 23, 2023

I'm also curious about that. It seems like we use it for transpiling jsx/tsx for Jest, and set the babel parser as the parser in the eslint-plugin-pf-react, but I don't see any other uses of it in the repo?

@wise-king-sullyman I think your question is different from Nicole's. Babel was used before we converted to TS. This is just left over for things that still needed it (like the docs when we used Gatsby). I do have an issue open to remove Babel.

Copy link
Contributor

@dlabaj dlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@nicolethoen nicolethoen merged commit db7babb into patternfly:v5 Mar 23, 2023
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-code-editor@5.0.0-alpha.45
  • @patternfly/react-core@5.0.0-alpha.45
  • @patternfly/react-docs@6.0.0-alpha.48
  • demo-app-ts@5.0.0-alpha.29
  • @patternfly/react-integration@5.0.0-alpha.13
  • @patternfly/react-table@5.0.0-alpha.45

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants