Skip to content

fix(Modal): updated position prop to have 'default' option #8855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2023
Merged

fix(Modal): updated position prop to have 'default' option #8855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e964c8d
fix(Modal): updated position prop to have 'default' option
wise-king-sullyman Mar 23, 2023
019ac0c
chore(Modal): updated position prop description
wise-king-sullyman Mar 24, 2023
bf96f51
chore(Modal): updated position prop description in other locations
wise-king-sullyman Mar 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/react-core/src/components/Modal/Modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ export interface ModalProps extends React.HTMLProps<HTMLDivElement>, OUIAProps {
/** Modal handles pressing of the escape key and closes the modal. If you want to handle
* this yourself you can use this callback function. */
onEscapePress?: (event: KeyboardEvent) => void;
/** Alternate position of the modal. */
position?: 'top';
/** Position of the modal. By default a modal will be positioned vertically and horizontally centered. */
position?: 'default' | 'top';
/** Offset from alternate position. Can be any valid CSS length/percentage. */
positionOffset?: string;
/** Flag to show the close button in the header area of the modal. */
Expand Down Expand Up @@ -113,7 +113,8 @@ export class Modal extends React.Component<ModalProps, ModalState> {
variant: 'default',
hasNoBodyWrapper: false,
appendTo: () => document.body,
ouiaSafe: true
ouiaSafe: true,
position: 'default'
};

constructor(props: ModalProps) {
Expand Down Expand Up @@ -230,6 +231,7 @@ export class Modal extends React.Component<ModalProps, ModalState> {
titleLabel,
ouiaId,
ouiaSafe,
position,
...props
} = this.props;
const { container } = this.state;
Expand All @@ -254,6 +256,7 @@ export class Modal extends React.Component<ModalProps, ModalState> {
bodyAriaRole={bodyAriaRole}
ouiaId={ouiaId !== undefined ? ouiaId : this.state.ouiaStateId}
ouiaSafe={ouiaSafe}
position={position}
/>,
container
) as React.ReactElement;
Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/components/Modal/ModalBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ export interface ModalBoxProps extends React.HTMLProps<HTMLDivElement> {
children: React.ReactNode;
/** Additional classes added to the modal box. */
className?: string;
/** Alternate position of the modal. */
position?: 'top';
/** Position of the modal. By default a modal will be positioned vertically and horizontally centered. */
position?: 'default' | 'top';
/** Offset from alternate position. Can be any valid CSS length/percentage. */
positionOffset?: string;
/** Variant of the modal. */
Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/components/Modal/ModalContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ export interface ModalContentProps extends OUIAProps {
labelId: string;
/** A callback for when the close button is clicked. */
onClose?: () => void;
/** Alternate position of the modal. */
position?: 'top';
/** Position of the modal. By default a modal will be positioned vertically and horizontally centered. */
position?: 'default' | 'top';
/** Offset from alternate position. Can be any valid CSS length/percentage. */
positionOffset?: string;
/** Flag to show the close button in the header area of the modal. */
Expand Down