docs(Backdrop): remove "with spinner" example #8860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-8860.surge.sh A11y report: https://patternfly-react-pr-8860-a11y.surge.sh |
mcarrano
approved these changes
Mar 24, 2023
Member
mcarrano
left a comment
mcarrano
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks @adamviktora !
tlabaj
reviewed
Mar 24, 2023
Contributor
tlabaj
left a comment
tlabaj
left a comment
There was a problem hiding this comment.
Do you mind updating the prop decription for class name while you are in the component. IT says "additional classes added to the button". It should be "Additional classes added to the backdrop"
nicolethoen
approved these changes
Mar 24, 2023
Contributor
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
LGTM - should be good to merge after addressing Titani's note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #8447