Skip to content

fix(Wizard): add type to nav item buttons #8876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2023
Merged

fix(Wizard): add type to nav item buttons #8876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/react-core/src/components/Wizard/WizardNavItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ export const WizardNavItem: React.FunctionComponent<WizardNavItemProps> = ({
}

const btnProps = {
disabled: isDisabled
disabled: isDisabled,
type: 'button' as const
};

const linkProps = {
Expand Down
1 change: 1 addition & 0 deletions ...-core/src/components/Wizard/__tests__/Generated/__snapshots__/WizardNavItem.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ exports[`WizardNavItem should match snapshot (auto-generated) 1`] = `
data-ouia-component-id="OUIA-Generated-WizardNavItem-1"
data-ouia-component-type="PF4/WizardNavItem"
data-ouia-safe="true"
type="button"
/>
ReactNode
</li>
Expand Down
13 changes: 13 additions & 0 deletions packages/react-core/src/components/Wizard/__tests__/__snapshots__/Wizard.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ exports[`Wizard Expandable Nav Wizard should match snapshot 1`] = `
data-ouia-component-id="OUIA-Generated-WizardNavItem-7"
data-ouia-component-type="PF4/WizardNavItem"
data-ouia-safe="true"
type="button"
>
A
</button>
Expand All @@ -125,6 +126,7 @@ exports[`Wizard Expandable Nav Wizard should match snapshot 1`] = `
data-ouia-component-id="OUIA-Generated-WizardNavItem-8"
data-ouia-component-type="PF4/WizardNavItem"
data-ouia-safe="true"
type="button"
>
<span
class="pf-c-wizard__nav-link-text"
Expand Down Expand Up @@ -166,6 +168,7 @@ exports[`Wizard Expandable Nav Wizard should match snapshot 1`] = `
data-ouia-component-id="OUIA-Generated-WizardNavItem-9"
data-ouia-component-type="PF4/WizardNavItem"
data-ouia-safe="true"
type="button"
>
B-1
</button>
Expand All @@ -179,6 +182,7 @@ exports[`Wizard Expandable Nav Wizard should match snapshot 1`] = `
data-ouia-component-id="OUIA-Generated-WizardNavItem-10"
data-ouia-component-type="PF4/WizardNavItem"
data-ouia-safe="true"
type="button"
>
B-2
</button>
Expand All @@ -194,6 +198,7 @@ exports[`Wizard Expandable Nav Wizard should match snapshot 1`] = `
data-ouia-component-id="OUIA-Generated-WizardNavItem-11"
data-ouia-component-type="PF4/WizardNavItem"
data-ouia-safe="true"
type="button"
>
C
</button>
Expand All @@ -207,6 +212,7 @@ exports[`Wizard Expandable Nav Wizard should match snapshot 1`] = `
data-ouia-component-id="OUIA-Generated-WizardNavItem-12"
data-ouia-component-type="PF4/WizardNavItem"
data-ouia-safe="true"
type="button"
>
D
</button>
Expand Down Expand Up @@ -381,6 +387,7 @@ exports[`Wizard Wizard should match snapshot 1`] = `
data-ouia-component-type="PF4/WizardNavItem"
data-ouia-safe="true"
id="step-A"
type="button"
>
A
</button>
Expand All @@ -395,6 +402,7 @@ exports[`Wizard Wizard should match snapshot 1`] = `
data-ouia-component-type="PF4/WizardNavItem"
data-ouia-safe="true"
id="step-B"
type="button"
>
B
</button>
Expand All @@ -412,6 +420,7 @@ exports[`Wizard Wizard should match snapshot 1`] = `
data-ouia-component-type="PF4/WizardNavItem"
data-ouia-safe="true"
id="step-B-1"
type="button"
>
B-1
</button>
Expand All @@ -426,6 +435,7 @@ exports[`Wizard Wizard should match snapshot 1`] = `
data-ouia-component-type="PF4/WizardNavItem"
data-ouia-safe="true"
id="step-B-2"
type="button"
>
B-2
</button>
Expand All @@ -442,6 +452,7 @@ exports[`Wizard Wizard should match snapshot 1`] = `
data-ouia-component-type="PF4/WizardNavItem"
data-ouia-safe="true"
id="step-C"
type="button"
>
C
</button>
Expand All @@ -456,6 +467,7 @@ exports[`Wizard Wizard should match snapshot 1`] = `
data-ouia-component-type="PF4/WizardNavItem"
data-ouia-safe="true"
id="step-D"
type="button"
>
D
</button>
Expand Down Expand Up @@ -586,6 +598,7 @@ exports[`Wizard bare wiz 1`] = `
data-ouia-component-id="OUIA-Generated-WizardNavItem-13"
data-ouia-component-type="PF4/WizardNavItem"
data-ouia-safe="true"
type="button"
>
A
</button>
Expand Down