Skip to content

Conversation

@tlabaj
Copy link
Contributor

@tlabaj tlabaj commented Mar 30, 2023

What: Closes #8890

@tlabaj tlabaj requested a review from nicolethoen March 30, 2023 13:50
@patternfly-build
Copy link
Contributor

patternfly-build commented Mar 30, 2023

@tlabaj tlabaj requested a review from thatblindgeye March 30, 2023 19:02
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this PR also cover closing #8775 entirely? If so I have some comments to followup with regarding that.

@nicolethoen
Copy link
Contributor

@thatblindgeye I don't imagine it should. The goal here is just to get the build passing with the latest from core so that the React issues written to address the core changes can be unblocked and worked on.

@tlabaj
Copy link
Contributor Author

tlabaj commented Mar 31, 2023

Should this PR also cover closing #8775 entirely? If so I have some comments to followup with regarding that.

No, this just gets the build to pass.

@nicolethoen nicolethoen merged commit 2de2e05 into patternfly:v5 Apr 3, 2023
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-charts@7.0.0-alpha.14
  • @patternfly/react-code-editor@5.0.0-alpha.52
  • @patternfly/react-core@5.0.0-alpha.51
  • @patternfly/react-docs@6.0.0-alpha.56
  • @patternfly/react-icons@5.0.0-alpha.8
  • demo-app-ts@5.0.0-alpha.35
  • @patternfly/react-integration@5.0.0-alpha.16
  • @patternfly/react-styles@5.0.0-alpha.6
  • @patternfly/react-table@5.0.0-alpha.52
  • @patternfly/react-tokens@5.0.0-alpha.6

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bump core version

5 participants