-
Notifications
You must be signed in to change notification settings - Fork 375
Add OUIA IDs for some components testing page #8893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OUIA IDs for some components testing page #8893
Conversation
|
Preview: https://patternfly-react-pr-8893.surge.sh A11y report: https://patternfly-react-pr-8893-a11y.surge.sh |
packages/react-core/src/components/Pagination/examples/PaginationTop.tsx
Outdated
Show resolved
Hide resolved
8791871 to
f97f47c
Compare
|
I went through all changes I made in generated page here and haven't found any issues. All OUIA IDs are in place (instead of autogenerated values we have some real now for a few components). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to add the ouiaId prop to each example - UI developers would not be using the ouaid prop except in testing, right?
As long as the ouiaId is listed in the component props tables at the bottom of the generated docs, that should cover us.
I can see the Alert docs do include ouiaId in the props table
|
@nicolethoen I'm setting OUIA IDs only for some examples for being able to use them in testing page https://patternfly-react-main.surge.sh/ . I'm just specifying some OUIA IDs (avoid autogeneration). It's not going to affect anything at all as it's only for doc/testing page. But we are going to use these ids to testing patternfly widgets that we make here https://github.com/RedHatQE/widgetastic.patternfly4 |
|
@tlabaj might have more background on how our examples should be updated or not. @LightOfHeaven1994 do you use the snippets from our example code in ouia tests? |
|
@nicolethoen in our tests we spin up Selenium container and navigate to your testing page and interacting with PF components using widgets (wrappers for your component in python for QE usage). For example, menu items selection https://github.com/RedHatQE/widgetastic.patternfly4/blob/master/testing/test_menu.py#L39 |
nicolethoen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this - so long as @tlabaj is okay with it.
tlabaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This just needs a rebase then we can merge.
f97f47c to
3ba67c7
Compare
5c0fdeb to
46ab04b
Compare
|
@tlabaj rebased, thanks! |
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
What: Closes #
Additional issues: