Skip to content

Conversation

@LightOfHeaven1994
Copy link
Contributor

What: Closes #

Additional issues:

@LightOfHeaven1994 LightOfHeaven1994 marked this pull request as draft March 31, 2023 14:40
@patternfly-build
Copy link
Contributor

patternfly-build commented Mar 31, 2023

@LightOfHeaven1994
Copy link
Contributor Author

I went through all changes I made in generated page here and haven't found any issues. All OUIA IDs are in place (instead of autogenerated values we have some real now for a few components).

@LightOfHeaven1994 LightOfHeaven1994 marked this pull request as ready for review April 3, 2023 14:08
Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to add the ouiaId prop to each example - UI developers would not be using the ouaid prop except in testing, right?

As long as the ouiaId is listed in the component props tables at the bottom of the generated docs, that should cover us.
I can see the Alert docs do include ouiaId in the props table

@LightOfHeaven1994
Copy link
Contributor Author

@nicolethoen I'm setting OUIA IDs only for some examples for being able to use them in testing page https://patternfly-react-main.surge.sh/ .
Right now if you open any Alert on a testing page you will see this HTML code (note that data-ouia-component-id is already here, it's just autogenerated):

<div class="pf-c-alert" aria-label="Default Alert" data-ouia-component-type="PF4/Alert" data-ouia-safe="true" data-ouia-component-id="OUIA-Generated-Alert-default-1">

I'm just specifying some OUIA IDs (avoid autogeneration). It's not going to affect anything at all as it's only for doc/testing page. But we are going to use these ids to testing patternfly widgets that we make here https://github.com/RedHatQE/widgetastic.patternfly4

@nicolethoen
Copy link
Contributor

@tlabaj might have more background on how our examples should be updated or not.

@LightOfHeaven1994 do you use the snippets from our example code in ouia tests?

@LightOfHeaven1994
Copy link
Contributor Author

@nicolethoen in our tests we spin up Selenium container and navigate to your testing page and interacting with PF components using widgets (wrappers for your component in python for QE usage). For example, menu items selection https://github.com/RedHatQE/widgetastic.patternfly4/blob/master/testing/test_menu.py#L39

Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this - so long as @tlabaj is okay with it.

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This just needs a rebase then we can merge.

@LightOfHeaven1994 LightOfHeaven1994 force-pushed the add-ouia-ids-testing-page branch from f97f47c to 3ba67c7 Compare April 11, 2023 07:30
@LightOfHeaven1994 LightOfHeaven1994 force-pushed the add-ouia-ids-testing-page branch from 5c0fdeb to 46ab04b Compare April 11, 2023 08:44
@LightOfHeaven1994
Copy link
Contributor Author

@tlabaj rebased, thanks!

@tlabaj tlabaj merged commit 4771aae into patternfly:v5 Apr 11, 2023
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-code-editor@5.0.0-alpha.63
  • @patternfly/react-core@5.0.0-alpha.62
  • @patternfly/react-docs@6.0.0-alpha.68
  • demo-app-ts@5.0.0-alpha.46
  • @patternfly/react-table@5.0.0-alpha.64

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants