Charts: box plot #8900
Merged
Charts: box plot #8900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-8900.surge.sh A11y report: https://patternfly-react-pr-8900-a11y.surge.sh |
dlabrecq
force-pushed
the
boxplot-chart
branch
5 times, most recently
from
5c62cdf to
b924866
Compare
Closed
kmcfaul
approved these changes
Apr 3, 2023
jenny-s51
reviewed
Apr 3, 2023
| </div> | ||
| ``` | ||
|
|
||
| ### Green with bottom aligned legend |
Contributor
There was a problem hiding this comment.
Should the title be updated to match the themeColor?
mcarrano
reviewed
Apr 5, 2023
Member
mcarrano
left a comment
mcarrano
left a comment
There was a problem hiding this comment.
I'm OK with this. But @mceledonia @andrew-ronaldson perhaps you should take a look to see if the styling is acceptable.
tlabaj
reviewed
Apr 6, 2023
| ```js | ||
| import React from 'react'; | ||
| import { Chart, ChartAxis, ChartBoxPlot, ChartCursorFlyout, ChartCursorTooltip, ChartThemeColor, createContainer } from '@patternfly/react-charts'; | ||
| // import '@patternfly/patternfly/patternfly-charts.css'; // Required for mix-blend-mode CSS property |
Contributor
There was a problem hiding this comment.
Is this intended as a note to help consumers or did you mean to remove it?
Member
Author
There was a problem hiding this comment.
This was intentional, but realized mix-blend-mode only applies to area charts. I removed the comment, thanks
nicolethoen
approved these changes
Apr 9, 2023
tlabaj
approved these changes
Apr 10, 2023
Contributor
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a component to wrap the Victory box plot chart with PatternFly styles and tooltip functionality.
Closes #8837