fix(Table): rename TdActionsType 'disable' prop to 'isDisabled' #8904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-8904.surge.sh A11y report: https://patternfly-react-pr-8904-a11y.surge.sh |
kmcfaul
approved these changes
Apr 3, 2023
jenny-s51
requested changes
Apr 3, 2023
Contributor
There was a problem hiding this comment.
Looking good @adamviktora! I see you made similar updates in #8861 and my inital PR comments were addressed there.
jenny-s51
approved these changes
Apr 3, 2023
tlabaj
approved these changes
Apr 5, 2023
Contributor
tlabaj
left a comment
tlabaj
left a comment
There was a problem hiding this comment.
LGTM. WE can merge once conflicts are resolved.
adamviktora
force-pushed
the
table-update-TdActionType
branch
from
8291e4f to
83e97dc
Compare
Contributor
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #8870
Additional issues:
codemod issue follows: patternfly/pf-codemods#354