Skip to content

Conversation

@nicolethoen
Copy link
Contributor

@nicolethoen nicolethoen commented Apr 4, 2023

What: Closes #8536

promotes:
Charts: Patterns
Date picker
Dropdown: bulk select loading state
Dropdown - next
Icon
LoginPage: header utilities
MenuItem: hasCheck
Multiple file upload with helper text
Progress stepper
Progress helper text
removeFindDomNode
SearchInput
Select next
Select: isCreateSelectOptionObject
Select: loadingVariant
Select: isInputFilterPersisted
Tabs: dynamic
Tabs: horizontal overflow
Tabs: actions
Tabs: close button props
Text area: icon sprite
Text input group
Tile
Truncate
Wizard next

Components/features still in beta after v5: https://docs.google.com/spreadsheets/d/17aEfvG1DZ0dZmpwacYaCzKv4sog0LuatXCwNizJ7HhE/edit#gid=1239116046

@patternfly-build
Copy link
Contributor

patternfly-build commented Apr 4, 2023

@nicolethoen nicolethoen requested review from mcarrano and tlabaj April 4, 2023 16:02
Copy link
Member

@mcarrano mcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks OK, but there were a few things I was missing as I reviewed the file updates so will defer to @tlabaj . Specifically, I didn't find updates that referenced:

  • LoginPage
  • removeFindDomNode

Also wasn't sure about all the Select changes, but I will admit to not being sure what I was looking for. But otherwise this looks good.

@tlabaj
Copy link
Contributor

tlabaj commented Apr 6, 2023

I think this looks OK, but there were a few things I was missing as I reviewed the file updates so will defer to @tlabaj . Specifically, I didn't find updates that referenced:

  • LoginPage
  • removeFindDomNode

@mcarrano removeFindDomNode was removed for v5 so should not be on this list
it looks like "Login Page header utilities was promoted already.
For select, Nicole promoted Next select. She also promoted an. beta features in the deprecated select.

Copy link
Member

@mcarrano mcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit 34c1688 into patternfly:v5 May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove beta tags for v5

6 participants