-
Notifications
You must be signed in to change notification settings - Fork 375
fix(beta): promote components + features out of beta for v5 #8912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview: https://patternfly-react-pr-8912.surge.sh A11y report: https://patternfly-react-pr-8912-a11y.surge.sh |
mcarrano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks OK, but there were a few things I was missing as I reviewed the file updates so will defer to @tlabaj . Specifically, I didn't find updates that referenced:
- LoginPage
- removeFindDomNode
Also wasn't sure about all the Select changes, but I will admit to not being sure what I was looking for. But otherwise this looks good.
@mcarrano |
7f59015 to
a4ac0c5
Compare
a4ac0c5 to
ff1e005
Compare
mcarrano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
tlabaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What: Closes #8536
promotes:
Charts: Patterns
Date picker
Dropdown: bulk select loading state
Dropdown - next
Icon
LoginPage: header utilities
MenuItem: hasCheck
Multiple file upload with helper text
Progress stepper
Progress helper text
removeFindDomNode
SearchInput
Select next
Select: isCreateSelectOptionObject
Select: loadingVariant
Select: isInputFilterPersisted
Tabs: dynamic
Tabs: horizontal overflow
Tabs: actions
Tabs: close button props
Text area: icon sprite
Text input group
Tile
Truncate
Wizard next
Components/features still in beta after v5: https://docs.google.com/spreadsheets/d/17aEfvG1DZ0dZmpwacYaCzKv4sog0LuatXCwNizJ7HhE/edit#gid=1239116046