feat(Sidebar): add border and padding #8918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-8918.surge.sh A11y report: https://patternfly-react-pr-8918-a11y.surge.sh |
mcarrano
reviewed
Apr 6, 2023
Member
mcarrano
left a comment
mcarrano
left a comment
There was a problem hiding this comment.
@tlabaj this looks fine to me, but I don't really have a sense about what this is trying to accomplish from a design perspective. @mceledonia perhaps you can take a look to see if there are any issues?
thatblindgeye
approved these changes
Apr 6, 2023
Contributor
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #8253
Adds
hasBordertoSidebar.Adds
hasPaddingtoSidebarPanelandSidebarContent.Adds examples & tests.