Alert - move files and combine docs for Alert and AlertGroup #8930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-8930.surge.sh A11y report: https://patternfly-react-pr-8930-a11y.surge.sh |
Member
Author
|
@nicolethoen @tlabaj I've put up this PR following our meeting earlier in the week. It combines the Alert and AlertGroup files into one directory called Alert. Please take a look and let me know if this is what you expected or if you see any issues. |
tlabaj
requested changes
Apr 12, 2023
Contributor
tlabaj
left a comment
tlabaj
left a comment
There was a problem hiding this comment.
Looks good! Just a couple of small comments
Contributor
|
The a11y tests are failing because there are two headings with the same name. I think we might need to rename Alert Group's Variants example to 'Alert group variants' rather than just 'Variants. |
Contributor
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines docs for Alert and AlertGroup into a single page called alert. Changes include:
alert.mdWhat: Closes #8539