fix(createIcon): Spread className to svg to fix broken images #8954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-8954.surge.sh A11y report: https://patternfly-react-pr-8954-a11y.surge.sh |
srambach
reviewed
Apr 13, 2023
| <svg | ||
| aria-hidden="true" | ||
| class="pf-svg" | ||
| class="pf-svg undefined" |
Member
There was a problem hiding this comment.
Is the undefined class supposed to be there?
Contributor
Author
There was a problem hiding this comment.
I don't t see it on the actual component in docs. I added a check to only spread the className when not undefined I am not sure why it is happening with snapshots.
Contributor
Author
There was a problem hiding this comment.
Ok, I updated our version of jest. I was seeing different results in CI vs in our workspace. Updating jest fixed it.
gitdallas
approved these changes
Apr 14, 2023
jenny-s51
approved these changes
Apr 14, 2023
| render() { | ||
| const { title, ...props } = this.props; | ||
| const { title, className, ...props } = this.props; | ||
| const classes = className ? `pf-svg ${className}` : "pf-svg"; |
srambach
approved these changes
Apr 26, 2023
Contributor
Author
Contributor
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #8936
Additional issues: Closes #8947
I updated the jest version. There was an issue with snaphots adding undefined attributes that was failing some tests.