feat(Modal): added event to onClose #8956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-8956.surge.sh A11y report: https://patternfly-react-pr-8956-a11y.surge.sh |
jenny-s51
reviewed
Apr 14, 2023
Contributor
There was a problem hiding this comment.
This is looking good @wise-king-sullyman - should we also update handleModalToggle in the examples to take the event param like we do with AboutModal?
Contributor
Author
|
@jenny-s51 we can, I didn't since it would just go unused and wasn't needed to be able to access other params, but I'm not opposed. |
thatblindgeye
approved these changes
Apr 18, 2023
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Looks good + codemod issue already created
wise-king-sullyman
force-pushed
the
modal-onClose-add-event
branch
from
487d9ac to
cc64f7d
Compare
jenny-s51
approved these changes
Apr 18, 2023
Contributor
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #8887
Additional issues: