chore(Wizard): updated demos to use new Wizard #8981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-8981.surge.sh A11y report: https://patternfly-react-pr-8981-a11y.surge.sh |
nicolethoen
requested changes
Apr 20, 2023
| title="Simple wizard in modal" | ||
| description="Simple wizard description" | ||
| steps={steps} | ||
| <Wizard |
Contributor
There was a problem hiding this comment.
Codesandbox is warning me that there is a key problem in this Wizard:
Check the render method of `WizardToggle`. See https://fb.me/react-warning-keys for more information.
in Fragment (created by WizardToggle)
in WizardToggle (created by WizardInternal)
in WizardInternal (created by Wizard)
in div (created by Wizard)
in WizardContextProvider (created by Wizard)
in Wizard (at index.js:62)
in div (created by ModalBox)
Contributor
There was a problem hiding this comment.
and a second key problem:
Check the render method of `WizardNavInternal`. See https://fb.me/react-warning-keys for more information.
in WizardNavItem (created by WizardNavInternal)
in WizardNavInternal (created by WizardInternal)
in div (created by WizardToggle)
in div (created by WizardToggle)
in WizardToggle (created by WizardInternal)
in WizardInternal (created by Wizard)
in div (created by Wizard)
in WizardContextProvider (created by Wizard)
in Wizard (at index.js:62)
Contributor
There was a problem hiding this comment.
These warnings are appearing in all these demos - and are manifesting as the following error in the workspace:
Uncaught Error: Minified React error #423; visit https://reactjs.org/docs/error-decoder.html?invariant=423 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
at Sl (5472.596e471a.bundle.js:2:3393845)
at bc (5472.596e471a.bundle.js:2:3381463)
at _c (5472.596e471a.bundle.js:2:3381391)
at mc (5472.596e471a.bundle.js:2:3381254)
at rc (5472.596e471a.bundle.js:2:3378061)
at oc (5472.596e471a.bundle.js:2:3376613)
at w (5472.596e471a.bundle.js:2:3429769)
at MessagePort.I (5472.596e471a.bundle.js:2:3430301)
Contributor
Author
There was a problem hiding this comment.
Looks like there was one WizardStep that I mistyped the id prop as just d, should be fixed in the latest push.
thatblindgeye
force-pushed
the
iss8867_wizardUsage
branch
from
bff15ab to
955d209
Compare
wise-king-sullyman
approved these changes
Apr 21, 2023
nicolethoen
approved these changes
Apr 24, 2023
Contributor
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #8867
Additional issues: